Skip to content

Commit 9831215

Browse files
authored
changed incorrect key name in apple auth adapter tests (#6861)
* replaced client_id with clientId * retroactively added breaking change to change log
1 parent 5743d75 commit 9831215

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,10 @@
4545

4646
### 4.2.0
4747
[Full Changelog](https://github.com/parse-community/parse-server/compare/4.1.0...4.2.0)
48+
49+
__BREAKING CHANGES:__
50+
- CHANGE: The Sign-In with Apple authentication adapter parameter `client_id` has been changed to `clientId`. If using the Apple authentication adapter, this change requires to update the Parse Server configuration accordingly. See [#6523](https://github.com/parse-community/parse-server/pull/6523) for details.
51+
___
4852
- UPGRADE: Parse JS SDK to 2.12.0 [#6548](https://github.com/parse-community/parse-server/pull/6548)
4953
- NEW: Support Group aggregation on multiple columns for Postgres [#6483](https://github.com/parse-community/parse-server/pull/6483). Thanks to [Siddharth Ramesh](https://github.com/srameshr).
5054
- FIX: Improve test reliability by instructing Travis to only install one version of Postgres [#6490](https://github.com/parse-community/parse-server/pull/6490). Thanks to

spec/AuthenticationAdapters.spec.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1165,7 +1165,7 @@ describe('apple signin auth adapter', () => {
11651165

11661166
it('(using client id as array) should throw error with missing id_token', async () => {
11671167
try {
1168-
await apple.validateAuthData({}, { client_id: ['secret'] });
1168+
await apple.validateAuthData({}, { clientId: ['secret'] });
11691169
fail();
11701170
} catch (e) {
11711171
expect(e.message).toBe('id token is invalid for this user.');
@@ -1249,7 +1249,7 @@ describe('apple signin auth adapter', () => {
12491249
try {
12501250
await apple.validateAuthData(
12511251
{ id: 'the_user_id', token: 'the_token' },
1252-
{ client_id: ['secret'] }
1252+
{ clientId: ['secret'] }
12531253
);
12541254
fail();
12551255
} catch (e) {
@@ -1411,7 +1411,7 @@ describe('apple signin auth adapter', () => {
14111411

14121412
// TODO: figure out a way to generate our own apple signed tokens, perhaps with a parse apple account
14131413
// and a private key
1414-
xit('(using client id as string) should throw error with invalid jwt client_id', async () => {
1414+
xit('(using client id as string) should throw error with invalid jwt clientId', async () => {
14151415
try {
14161416
await apple.validateAuthData(
14171417
{ id: 'INSERT ID HERE', token: 'INSERT APPLE TOKEN HERE' },
@@ -1425,7 +1425,7 @@ describe('apple signin auth adapter', () => {
14251425

14261426
// TODO: figure out a way to generate our own apple signed tokens, perhaps with a parse apple account
14271427
// and a private key
1428-
xit('(using client id as array) should throw error with invalid jwt client_id', async () => {
1428+
xit('(using client id as array) should throw error with invalid jwt clientId', async () => {
14291429
try {
14301430
await apple.validateAuthData(
14311431
{ id: 'INSERT ID HERE', token: 'INSERT APPLE TOKEN HERE' },

0 commit comments

Comments
 (0)