Only accept strings as messages

Author: flovilmart

spec/CloudCode.spec.js

@@ -1080,7 +1080,8 @@ it('beforeSave should not affect fetched pointers', done => {
 
     it('should set the message / success on the job', (done) => {
       Parse.Cloud.job('myJob', (req, res) => {
-        res.message('hello').then(() => {
+        res.message('hello');
+        res.message().then(() => {
           return getJobStatus(req.jobId);
         }).then((jobStatus) => {
           expect(jobStatus.get('message')).toEqual('hello');
@@ -1089,7 +1090,7 @@ it('beforeSave should not affect fetched pointers', done => {
             return getJobStatus(req.jobId);
           });
         }).then((jobStatus) => {
-          expect(typeof jobStatus.get('message')).not.toBe('string');
+          expect(jobStatus.get('message')).toEqual('hello');
           expect(jobStatus.get('status')).toEqual('succeeded');
           done();
         }).catch(err => {

src/StatusHandler.js

@@ -63,6 +63,9 @@ export function jobStatusHandler(config) {
   }
 
   let setMessage = function(message) {
+    if (!message || typeof message !== 'string') {
+      return Promise.resolve();
+    }
     return handler.update({ objectId }, { message });
   }
 
@@ -74,9 +77,13 @@ export function jobStatusHandler(config) {
     return setFinalStatus('failed', message);
   }
 
-  let setFinalStatus = function(status, message = null) {
+  let setFinalStatus = function(status, message = undefined) {
     let finishedAt = new Date();
-    return handler.update({ objectId }, { status, message, finishedAt });
+    let update = { status, finishedAt };
+    if (message && typeof message === 'string') {
+      update.message = message;
+    }
+    return handler.update({ objectId }, update);
   }
 
   return Object.freeze({