pass authData to challenge method

Author: Moumouls

spec/AuthenticationAdapters.spec.js

@@ -2204,10 +2204,11 @@ describe('Auth Adapter features', () => {
     expect(challengeAdapter.challenge).toHaveBeenCalledTimes(1);
     expect(challengeCall[0]).toEqual({ someData: true });
     expect(challengeCall[1]).toBeUndefined();
-    expect(challengeCall[2].config).toBeDefined();
-    expect(challengeCall[2].auth).toBeDefined();
-    expect(challengeCall[2].config.headers).toBeDefined();
-    expect(challengeCall[2]).toBeDefined({ anOption: true });
+    expect(challengeCall[2]).toBeUndefined();
+    expect(challengeCall[3].config).toBeDefined();
+    expect(challengeCall[3].auth).toBeDefined();
+    expect(challengeCall[3].config.headers).toBeDefined();
+    expect(challengeCall[4]).toEqual({ anOption: true });
   });
   it('should return challenge with username created user', async () => {
     spyOn(challengeAdapter, 'challenge').and.resolveTo({ token: 'test' });
@@ -2284,12 +2285,13 @@ describe('Auth Adapter features', () => {
     const challengeCall = challengeAdapter.challenge.calls.argsFor(0);
     expect(challengeAdapter.challenge).toHaveBeenCalledTimes(1);
     expect(challengeCall[0]).toEqual({ someData: true });
-    expect(challengeCall[1] instanceof Parse.User).toBeTruthy();
-    expect(challengeCall[1].id).toEqual(user.id);
-    expect(challengeCall[2].config).toBeDefined();
-    expect(challengeCall[2].auth).toBeDefined();
-    expect(challengeCall[2].config.headers).toBeDefined();
-    expect(challengeCall[2]).toBeDefined({ anOption: true });
+    expect(challengeCall[1]).toEqual(undefined);
+    expect(challengeCall[2] instanceof Parse.User).toBeTruthy();
+    expect(challengeCall[2].id).toEqual(user.id);
+    expect(challengeCall[3].config).toBeDefined();
+    expect(challengeCall[3].auth).toBeDefined();
+    expect(challengeCall[3].config.headers).toBeDefined();
+    expect(challengeCall[4]).toEqual({ anOption: true });
   });
   it('should return challenge with authData created user', async () => {
     spyOn(challengeAdapter, 'challenge').and.resolveTo({ token: 'test' });
@@ -2367,11 +2369,12 @@ describe('Auth Adapter features', () => {
     const challengeCall = challengeAdapter.challenge.calls.argsFor(0);
     expect(challengeAdapter.challenge).toHaveBeenCalledTimes(1);
     expect(challengeCall[0]).toEqual({ someData: true });
-    expect(challengeCall[1] instanceof Parse.User).toBeTruthy();
-    expect(challengeCall[1].id).toEqual(user.id);
-    expect(challengeCall[2].config).toBeDefined();
-    expect(challengeCall[2].auth).toBeDefined();
-    expect(challengeCall[2].config.headers).toBeDefined();
-    expect(challengeCall[2]).toBeDefined({ anOption: true });
+    expect(challengeCall[1]).toEqual({ id: 'challengeAdapter' });
+    expect(challengeCall[2] instanceof Parse.User).toBeTruthy();
+    expect(challengeCall[2].id).toEqual(user.id);
+    expect(challengeCall[3].config).toBeDefined();
+    expect(challengeCall[3].auth).toBeDefined();
+    expect(challengeCall[3].config.headers).toBeDefined();
+    expect(challengeCall[4]).toEqual({ anOption: true });
   });
 });

src/Adapters/Auth/AuthAdapter.js

@@ -50,11 +50,12 @@ export class AuthAdapter {
   /**
    *
    * @param challengeData: data provided by the client
+   * @param authData: auth data provided by the client, can be used for validation
    * @param options: additional options
    * @param req: RestWrite instance with config/auth/data
    * @returns a promise that resolves, resolved value will be added to challenge response under challenge key
    */
-  challenge(challengeData, options, req) {
+  challenge(challengeData, authData, options, req) {
     return Promise.resolve({});
   }
 }

src/Routers/UsersRouter.js

@@ -476,6 +476,7 @@ export class UsersRouter extends ClassesRouter {
           acc[provider] =
             (await authAdapters[provider].challenge(
               challengeData[provider],
+              authData && authData[provider],
               user ? Parse.User.fromJSON({ className: '_User', ...user }) : undefined,
               req,
               authAdapters[provider].options