Skip to content

Commit e4471bb

Browse files
committed
remove className as invalid
1 parent 90af079 commit e4471bb

File tree

4 files changed

+9
-49
lines changed

4 files changed

+9
-49
lines changed

spec/ParseObject.spec.js

Lines changed: 1 addition & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -701,29 +701,24 @@ describe('Parse.Object testing', () => {
701701
});
702702
});
703703

704-
it('length attribute', function (done) {
704+
it('acl attribute', function (done) {
705705
Parse.User.signUp('bob', 'password').then(function (user) {
706706
const TestObject = Parse.Object.extend('TestObject');
707707
const obj = new TestObject({
708-
length: 5,
709708
ACL: new Parse.ACL(user), // ACLs cause things like validation to run
710709
});
711-
equal(obj.get('length'), 5);
712710
ok(obj.get('ACL') instanceof Parse.ACL);
713711

714712
obj.save().then(function (obj) {
715-
equal(obj.get('length'), 5);
716713
ok(obj.get('ACL') instanceof Parse.ACL);
717714

718715
const query = new Parse.Query(TestObject);
719716
query.get(obj.id).then(function (obj) {
720-
equal(obj.get('length'), 5);
721717
ok(obj.get('ACL') instanceof Parse.ACL);
722718

723719
const query = new Parse.Query(TestObject);
724720
query.find().then(function (results) {
725721
obj = results[0];
726-
equal(obj.get('length'), 5);
727722
ok(obj.get('ACL') instanceof Parse.ACL);
728723

729724
done();
@@ -2045,15 +2040,4 @@ describe('Parse.Object testing', () => {
20452040
const object = new Parse.Object('CloudCodeIsNew');
20462041
await object.save();
20472042
});
2048-
2049-
it('cannot save object with invalid field', async () => {
2050-
const obj = new TestObject();
2051-
obj.set('className', 'bar');
2052-
try {
2053-
await obj.save();
2054-
expect(false).toBe(true);
2055-
} catch (e) {
2056-
expect(e.message).toBe('Invalid field name: className.');
2057-
}
2058-
});
20592043
});

spec/ParseQuery.spec.js

Lines changed: 7 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -2860,31 +2860,17 @@ describe('Parse.Query testing', () => {
28602860
});
28612861
});
28622862

2863-
it('object with length', function (done) {
2863+
it('object with length', async () => {
28642864
const TestObject = Parse.Object.extend('TestObject');
28652865
const obj = new TestObject();
28662866
obj.set('length', 5);
28672867
equal(obj.get('length'), 5);
2868-
obj.save().then(
2869-
function () {
2870-
const query = new Parse.Query(TestObject);
2871-
query.find().then(
2872-
function (results) {
2873-
equal(results.length, 1);
2874-
equal(results[0].get('length'), 5);
2875-
done();
2876-
},
2877-
function (error) {
2878-
ok(false, error.message);
2879-
done();
2880-
}
2881-
);
2882-
},
2883-
function (error) {
2884-
ok(false, error.message);
2885-
done();
2886-
}
2887-
);
2868+
try {
2869+
await obj.save();
2870+
expect(false).toBe(true);
2871+
} catch (e) {
2872+
expect(e.message).toBe('Invalid field name: length.');
2873+
}
28882874
});
28892875

28902876
it('include user', function (done) {

spec/Schema.spec.js

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -123,16 +123,6 @@ describe('SchemaController', () => {
123123
);
124124
});
125125

126-
it('validate invalid column names', async () => {
127-
const schema = await config.database.loadSchema();
128-
try {
129-
await schema.validateObject('Stuff', { className: 'Unknown' });
130-
expect(false).toBe(true);
131-
} catch (e) {
132-
expect(e.message).toBe('Invalid field name: className.');
133-
}
134-
});
135-
136126
it('updates when new fields are added', done => {
137127
config.database
138128
.loadSchema()

src/Controllers/SchemaController.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ const requiredColumns = Object.freeze({
155155
_Role: ['name', 'ACL'],
156156
});
157157

158-
const invalidColumns = ['className', 'length'];
158+
const invalidColumns = ['length'];
159159

160160
const systemClasses = Object.freeze([
161161
'_User',

0 commit comments

Comments
 (0)