Strip read only fields from serialized beforeSave response objects

Author: TylerBrock

spec/ParseAPI.spec.js

@@ -1062,6 +1062,27 @@ describe('miscellaneous', function() {
      })
   })
 
+  it('does not think objects are dirty after saving them', (done) => {
+    let headers = {
+      'Content-Type': 'application/json',
+      'X-Parse-Application-Id': 'test',
+      'X-Parse-REST-API-Key': 'rest'
+    };
+    let requestOptions = {
+      headers: headers,
+      url: 'http://localhost:8378/1/classes/AnObject',
+      json: true
+    };
+    let object = new Parse.Object('AnObject');
+    object.set('cool', true);
+
+    request.post(requestOptions, (err, res, body) => {
+      console.log(body);
+      expect(body.updatedAt).toBeUndefined();
+      done();
+    });
+  })
+
   it('ignores _RevocableSession "header" send by JS SDK', (done) => {
     let object = new Parse.Object('AnObject');
     object.set('a', 'b');

spec/ParseHooks.spec.js

@@ -387,10 +387,10 @@ describe('Hooks', () => {
      Parse.Hooks.createTrigger("SomeRandomObject", "beforeSave" ,hookServerURL+"/BeforeSaveSome").then(function(){
        const obj = new Parse.Object("SomeRandomObject");
        return obj.save();
-     }).then(function(res){
+     }).then(function(res) {
        expect(triggerCount).toBe(1);
        return res.fetch();
-     }).then(function(res){
+     }).then(function(res) {
        expect(res.get("hello")).toEqual("world");
        done();
      }).fail((err) => {
@@ -400,6 +400,26 @@ describe('Hooks', () => {
      });
    });
 
+   it("beforeSave hooks should correctly handle responses containing entire object", (done) => {
+     app.post("/BeforeSaveSome2", function(req, res) {
+       var object = Parse.Object.fromJSON(req.body.object);
+       object.set('hello', "world");
+       res.json({success: object});
+     });
+     Parse.Hooks.createTrigger("SomeRandomObject2", "beforeSave" ,hookServerURL+"/BeforeSaveSome2").then(function(){
+       const obj = new Parse.Object("SomeRandomObject2");
+       return obj.save();
+     }).then(function(res) {
+       return res.save();
+     }).then(function(res) {
+       expect(res.get("hello")).toEqual("world");
+       done();
+     }).fail((err) => {
+       fail(`Should not fail: ${JSON.stringify(err)}`);
+       done();
+     });
+   });
+
    it("should run the afterSave hook on the test server", (done) => {
      var triggerCount = 0;
      var newObjectId;

src/Controllers/HooksController.js

@@ -205,6 +205,8 @@ function wrapToHTTPRequest(hook, key) {
       if (err) {
         return res.error(err);
       } else if (hook.triggerName === 'beforeSave') {
+        delete result.createdAt;
+        delete result.updatedAt;
         return res.success({object: result});
       } else {
         return res.success(result);