Sets encoding to null to preserve raw buffers

Author: flovilmart

spec/HTTPRequest.spec.js

@@ -213,5 +213,16 @@ describe("httpRequest", () => {
         done();
       }
     });
+  });
+  
+  it('should get a cat image', (done) => {
+    httpRequest({
+      url: 'http://thecatapi.com/api/images/get?format=src&type=jpg',
+      followRedirects: true
+    }).then((res) => {
+      expect(res.buffer).not.toBe(null);
+      expect(res.text).not.toBe(null);
+      done();
+    })
   })
 });

src/cloud-code/httpRequest.js

@@ -45,7 +45,8 @@ module.exports = function(options) {
   options = encodeBody(options);
   // set follow redirects to false by default
   options.followRedirect = options.followRedirects == true;
-  
+  // force the response as a buffer
+  options.encoding = null;
   request(options, (error, response, body) => {
     if (error) {
       if (callbacks.error) {
@@ -56,11 +57,11 @@ module.exports = function(options) {
     var httpResponse = {};
     httpResponse.status = response.statusCode;
     httpResponse.headers = response.headers;
-    httpResponse.buffer = new Buffer(response.body);
+    httpResponse.buffer = response.body;
     httpResponse.cookies = response.headers["set-cookie"];
-    httpResponse.text = response.body;
+    httpResponse.text = response.body.toString('utf-8');
     try {
-      httpResponse.data = JSON.parse(response.body);
+      httpResponse.data = JSON.parse(httpResponse.text);
     } catch (e) {}
     // Consider <200 && >= 400 as errors 
     if (httpResponse.status < 200 || httpResponse.status >= 400) {