Throw error if $relativeTime is invalid

Marvel Mathew · Marvel Mathew · commit f28f3fd02424 · 2017-10-25T10:13:02.000-04:00
diff --git a/src/Adapters/Storage/Mongo/MongoTransform.js b/src/Adapters/Storage/Mongo/MongoTransform.js
@@ -536,7 +536,7 @@ function transformTopLevelAtom(atom, field) {
 function relativeTimeToDate(text, now = new Date()) {
   let parts = text.split(' ');
   if (!parts.length) {
-    return { status: 'invalid', info: 'Not a time string' };
+    return { status: 'error', info: 'Not a time string' };
   }
 
   // Filter out whitespace
@@ -672,9 +672,8 @@ function transformConstraint(constraint, field) {
           break;
         }
 
-        if (parserResult.status === 'error') {
-          log.info('Error while parsing relative date', parserResult);
-        }
+        log.info('Error while parsing relative date', parserResult);
+        throw new Parse.Error(Parse.Error.INVALID_JSON, `bad $relativeTime (${key}) value. ${parserResult.info}`);
       }
 
       answer[key] = transformer(constraint[key]);

Original file line number	Diff line number	Diff line change
`@@ -536,7 +536,7 @@ function transformTopLevelAtom(atom, field) {`
`536`	`536`	`function relativeTimeToDate(text, now = new Date()) {`
`537`	`537`	`let parts = text.split(' ');`
`538`	`538`	`if (!parts.length) {`
`539`		`- return { status: 'invalid', info: 'Not a time string' };`
	`539`	`+ return { status: 'error', info: 'Not a time string' };`
`540`	`540`	`}`
`541`	`541`
`542`	`542`	`// Filter out whitespace`
`@@ -672,9 +672,8 @@ function transformConstraint(constraint, field) {`
`672`	`672`	`break;`
`673`	`673`	`}`
`674`	`674`
`675`		`- if (parserResult.status === 'error') {`
`676`		`- log.info('Error while parsing relative date', parserResult);`
`677`		`- }`
	`675`	`+ log.info('Error while parsing relative date', parserResult);`
	`676`	+ throw new Parse.Error(Parse.Error.INVALID_JSON, `bad $relativeTime (${key}) value. ${parserResult.info}`);
`678`	`677`	`}`
`679`	`678`
`680`	`679`	`answer[key] = transformer(constraint[key]);`