Fix logic for missing geo index error message check #1824
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Sweet. What was the change in Mongo that made this change necessary? |
|
None, the logic was just wrong :-) |
|
The second condition was never checked with the || and so even though there was a match for that error message in MongoDB 3.2 when the index is missing it still threw. You might be wondering why the error code changed or is no longer reported now, that I don't know but essentially that is the change. |
|
Interesting. Error codes are something I would expect to not change between versions. Well, feel free to merge whenever you want. |
|
I might do some more digging and file a JIRA ticket about this instead. |
|
Submitted: https://jira.mongodb.org/browse/SERVER-24198 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will get the ParseGeoPoint.spec tests passing with MongoDB 3.2