Change existsSync to exception handler #1879
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Build failure is caused by mongo download issues, merging anyway. |
JeremyPlease
pushed a commit
to JeremyPlease/parse-server
that referenced
this pull request
May 24, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gs.existsSync is deprecated but fs.statSync could give incorrect results if a concurrent process creates the folder. We could check for a specific error case but as there is no error handling currently, e.g. for not having write permission, the intention of this PR is just to fix the bug #1806
http://stackoverflow.com/questions/28532820/fs-exists-fs-existssync-why-are-they-deprecated