Fix database URI #1911
Merged
Fix database URI #1911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Current coverage is 91.83%@@ master #1911 diff @@
==========================================
Files 91 91
Lines 6377 6377
Methods 1111 1111
Messages 0 0
Branches 1335 1335
==========================================
Hits 5856 5856
Misses 521 521
Partials 0 0
|
|
Would it be better to consider setting the uri on travis somehow or detect we are running on Travis and use the hardcoded value if so? |
|
Is there any particular reason you would want to use a different URI in different environments? If so, sure. You shouldn't have to set environment variables in order to run the tests though. |
|
Sounds good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
process.env.DATABASE_URIisundefinedon Travis, lets use an explicit database.