Fix expected webhook external response format #1934
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Current coverage is 91.85%@@ master #1934 diff @@
==========================================
Files 91 91
Lines 6394 6396 +2
Methods 1112 1097 -15
Messages 0 0
Branches 1339 1340 +1
==========================================
+ Hits 5873 5875 +2
Misses 521 521
Partials 0 0
|
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The actual contract between parse-server and external webhooks specifies that the response to a beforeSave return the object directly instead of wrapped in an object under a key named "object" (like it does in cloud code)