Make beforeSave work when object is passed to success #1937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Current coverage is 91.86%@@ master #1937 diff @@
==========================================
Files 91 91
Lines 6396 6397 +1
Methods 1097 1097
Messages 0 0
Branches 1340 1341 +1
==========================================
+ Hits 5875 5876 +1
Misses 521 521
Partials 0 0
|
|
We have a test for the use case I'm concerned about so this looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1928
The tests all pass, but @TylerBrock please check that this doesn't break any webhooks stuff
cc @flovilmart