Allow custom error codes with response.error #1955
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s and before/after hooks
ghost
added
the
Current coverage is 91.84%@@ master #1955 diff @@
==========================================
Files 91 91
Lines 6394 6400 +6
Methods 1094 1094
Messages 0 0
Branches 1341 1343 +2
==========================================
+ Hits 5872 5878 +6
Misses 522 522
Partials 0 0
|
|
Awesome! I think this is a great idea. Because it includes a new public API, I'd like to see what other members of the community think before merging @TylerBrock @flovilmart @nlutsenko |
|
I'm happy with it! |
|
@TylerBrock any objection? Marking it as OK |
|
Looks great to me. I like it. |
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1950.
Previously,
response.error(...)from Cloud Code or before/after hooks would always use the error code "141" (Parse.Error.SCRIPT_FAILED).This PR updates
response.errorto accept two parameters: an error code and a message. If no error code is passed then the standard "141" will be used.