Add more postgres support #2080
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More passing postgres tests Handle schema updates, and $in for non array columns remove authdata from user and implement ensureUniqueness Make some tests work, detect existing classes Throw proper error for unique index violation
ghost
added
the
| delete schema.fields._hashed_password; | ||
| schema.fields.password = { type: 'String' }; | ||
| } | ||
|
|
||
| return schema; | ||
| } | ||
|
|
||
| const injectDefaultSchema = schema => ({ | ||
| className: schema.className, | ||
| const injectDefaultSchema = ({className, fields, classLevelPermissions}) => ({ |
Current coverage is 91.91%@@ master #2080 diff @@
==========================================
Files 93 93
Lines 6692 6715 +23
Methods 1183 1192 +9
Messages 0 0
Branches 1401 1410 +9
==========================================
+ Hits 6119 6172 +53
+ Misses 573 543 -30
Partials 0 0
|
|
nice! looks super clean. |
|
Is this a Postgres database adapter ? Can I use to replace mongodb ? When is the official release ? |
|
Can I try it ? Super excited ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also cleans up authData handling a bit. Note that in order to create the username/email unique constraint in Postgres, that means the _User class needs to exist, so we are now creating it when the server starts.