Skip to content

Update bootstrap.sh #2862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 13, 2016
Merged

Update bootstrap.sh #2862

merged 2 commits into from
Oct 13, 2016

Conversation

flovilmart
Copy link
Contributor

Fix issue when generating config.json

@flovilmart
Update bootstrap.sh
d35485b 
Fix issue when generating config.json
@flovilmart
Update bootstrap.sh
9558964 
Fix mongodb URI
@facebook-github-bot
Copy link

@flovilmart updated the pull request - view changes

acinader
acinader approved these changes Oct 13, 2016
View reviewed changes
Copy link
Contributor

@acinader acinader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a grep on appId & applicationId. Looks like both are used a lot which would be a nice thing to fix?

In any event, if I've got it right, this is writing out the parse-server configuration, so appId is correct.

lgtm

@flovilmart
Copy link
Contributor Author

Yeah, historically, Parse SDK used applicationId with Parse-server, a few letters have been removed that's why it's a bit confusing...

@flovilmart flovilmart merged commit c253daa into master Oct 13, 2016
@flovilmart flovilmart deleted the patch-bootstrap branch October 13, 2016 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acinader acinader acinader approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@flovilmart @facebook-github-bot @acinader