requiresAuthentication is self-sufficient for ACL's #3784
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3784 +/- ##
==========================================
- Coverage 90.26% 90.14% -0.13%
==========================================
Files 114 114
Lines 7491 7549 +58
==========================================
+ Hits 6762 6805 +43
- Misses 729 744 +15
Continue to review full report at Codecov.
|
natanrolnik
reviewed
May 11, 2017
spec/Schema.spec.js
Outdated
| username: 'user', | ||
| password: 'password' | ||
| }) | ||
| return Parse.User.signUp('user', 'password').then(() => { |
There was a problem hiding this comment.
Wouldn't it be a more complete test case to check that a query, before user signs up, returns 0 results?
There was a problem hiding this comment.
I could do that yes :)
natanrolnik
approved these changes
May 11, 2017
acinader
approved these changes
May 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially, requiresAuthentication CLP would not let through if other CLP's were conflicting (like in #3753)
This PR changes the behaviour of requiresAuthentication to match other CLP processing which is, if it pass, we move forward in the processing.