Fix push controller tests.

[aontas]

A whole bunch of the PushController tests never actually tested to ensure that they actually did what they thought they did. In some cases, no pushes were ever sent at all.

For example the following query will never actually push to anything:

{
  'deviceToken': {
    '$inQuery': {
      'where': { 'deviceType': 'ios' },
      className: '_Installation'
    }
  }
}

Why? Because the result of the $inQuery is an array of _Installation object pointers and no deviceToken is an installation object.

Previously, the only thing that was actually testing was that no crash happened when passing in a query that would return no results.

[codecov]

Codecov Report

Merging #3853 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3853      +/-   ##
==========================================
- Coverage   90.25%   90.17%   -0.08%     
==========================================
  Files         114      114              
  Lines        7550     7550              
==========================================
- Hits         6814     6808       -6     
- Misses        736      742       +6

Impacted Files	Coverage Δ
src/Adapters/Cache/InMemoryCache.js	92.3% <0%> (-7.7%)	⬇️
...rc/Adapters/Storage/Mongo/MongoSchemaCollection.js	94.44% <0%> (-2.78%)	⬇️
src/StatusHandler.js	99.05% <0%> (-0.95%)	⬇️
...dapters/Storage/Postgres/PostgresStorageAdapter.js	95.46% <0%> (-0.14%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67a1da8...2788231. Read the comment docs.

[aontas]

I guess this reduces coverage as there is no longer a test that does nothing?

[flovilmart]

@aontas the codecov is sometimes weird, we have that from times to times, I suspect it's because of babel etc...

[acinader]

not asking you to change, just an fyi, this can be written nice and tersely:

.catch(done.fail);

[aontas]

Cool, thanks!