Endpoints for audiences CRUD #3861
Conversation
src/Routers/AudiencesRouter.js
Outdated
| } | ||
|
|
||
| mountRoutes() { | ||
| this.route('GET','/push_audiences', req => { return this.handleFind(req); }); |
There was a problem hiding this comment.
we need to protect those for masterKey only please
src/Routers/AudiencesRouter.js
Outdated
| } | ||
|
|
||
| return rest.find(req.config, req.auth, | ||
| '_Audience', body.where, options, req.info.clientSDK) |
There was a problem hiding this comment.
can you put it all on 1 line to match style.
|
@davimacedo bump? I’d like to get that in for 2.5.0! |
Codecov Report
@@ Coverage Diff @@
## master #3861 +/- ##
==========================================
+ Coverage 90.47% 90.49% +0.01%
==========================================
Files 114 115 +1
Lines 7686 7723 +37
==========================================
+ Hits 6954 6989 +35
- Misses 732 734 +2
Continue to review full report at Codecov.
|
|
Sorry about the delay. Done. |
|
I also fixed it to work on postgres |
|
Just added few more tests |
|
Awesome! Let’s get that in! |
|
Rebased, resolved the conflict and also lint problems due to e94991b |
|
Good! Thanks @davimacedo. |
|
Did you run |
|
Fixed. Yes. I have run all tests before pushing, but I had not yet updated the node modules. The new modules of the last commit are requiring new lint rules. |
No description provided.