Skip to content

Put loose test into a describe block where it belongs... #3920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

acinader
Copy link
Contributor

@acinader acinader commented Jun 9, 2017

  1. prefer const since i am touching the file.
  2. move a test that was outside its describe where it belongs.

this is really a no-op style pr since i am touching file for another issue....

@codecov
Copy link

codecov bot commented Jun 9, 2017

Codecov Report

Merging #3920 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3920      +/-   ##
==========================================
+ Coverage   90.24%   90.25%   +0.01%     
==========================================
  Files         114      114              
  Lines        7584     7584              
==========================================
+ Hits         6844     6845       +1     
+ Misses        740      739       -1
Impacted Files Coverage Δ
src/RestWrite.js 93.32% <0%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4fbc1f...65aa49e. Read the comment docs.

@acinader acinader requested a review from natanrolnik June 12, 2017 16:30
@flovilmart flovilmart merged commit 5f991e9 into parse-community:master Jun 13, 2017
@flovilmart flovilmart modified the milestone: 2.5.0 Jun 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants