Skip to content

Remove warning for invalid MongoDB driver option #3952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

TylerBrock
Copy link
Contributor

MongoDB driver prints: "the options [maxTimeMS] is not supported" when parse server starts when you have the database option maxTimeMS set. This is because it's a query option that gets passed to each query in order to limit the execution time and is not a driver level option.

The way the Mongo adapter works is that we pass this option along with others directly into the driver but this one should not be passed in so we can avoid the warning.

@codecov
Copy link

codecov bot commented Jun 24, 2017

Codecov Report

Merging #3952 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3952      +/-   ##
==========================================
+ Coverage   90.55%   90.57%   +0.01%     
==========================================
  Files         115      115              
  Lines        7783     7784       +1     
==========================================
+ Hits         7048     7050       +2     
+ Misses        735      734       -1
Impacted Files Coverage Δ
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 92.06% <100%> (+0.04%) ⬆️
src/RestWrite.js 93.48% <0%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a48044c...6560a00. Read the comment docs.

@flovilmart flovilmart added this to the 2.5.0 milestone Jun 25, 2017
@flovilmart flovilmart merged commit fedb381 into parse-community:master Jun 25, 2017
@flovilmart flovilmart modified the milestone: 2.5.0 Jun 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants