Skip to content

fix(vkontakte auth adapter): replace deadlocked promise with a live one #3956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2017
Merged

Conversation

denistrofimov
Copy link
Contributor

Tested in production

@codecov
Copy link

codecov bot commented Jun 26, 2017

Codecov Report

Merging #3956 into master will increase coverage by 0.01%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3956      +/-   ##
==========================================
+ Coverage   90.58%   90.59%   +0.01%     
==========================================
  Files         115      115              
  Lines        7784     7784              
==========================================
+ Hits         7051     7052       +1     
+ Misses        733      732       -1
Impacted Files Coverage Δ
src/Adapters/Auth/vkontakte.js 33.33% <33.33%> (+6.66%) ⬆️
...dapters/Storage/Postgres/PostgresStorageAdapter.js 96.15% <0%> (-0.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fedb381...50a29bc. Read the comment docs.

@flovilmart flovilmart merged commit 91193c7 into parse-community:master Jun 26, 2017
@flovilmart flovilmart added this to the 2.5.0 milestone Jun 26, 2017
@denistrofimov
Copy link
Contributor Author

@flovilmart thank you!

@flovilmart
Copy link
Contributor

@denistrofimov no problem! I'll do my best to craft 2.5.0 for today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants