Skip to content

Lets increment/set badges on all _Installations #3970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 3, 2017

Conversation

flovilmart
Copy link
Contributor

@flovilmart flovilmart commented Jun 28, 2017

We're gonna be working on supporting the badge property on android devices (through the GCM payload) for AmpMe, and we need to start incrementing/settings those values.

@flovilmart flovilmart requested a review from acinader June 28, 2017 18:24
@flovilmart
Copy link
Contributor Author

flovilmart commented Jun 28, 2017

We ran the test against our test android devices and it's possible to receive read the badge value there:

Bundle[{google.sent_time=1498679154373, push_id=x3jKNilLMw, data=
{"badge":5, "alert": "Yo!"}
, from=152312640838, time=2017-06-28T19:45:54.170Z, google.message_id=0:1498679154381204%cf4ebc7ff9fd7ecd, mp_icnm=icn_notification, parseWakeLockId=1}]

@codecov
Copy link

codecov bot commented Jun 28, 2017

Codecov Report

Merging #3970 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3970      +/-   ##
==========================================
- Coverage   90.58%   90.57%   -0.02%     
==========================================
  Files         115      115              
  Lines        7788     7786       -2     
==========================================
- Hits         7055     7052       -3     
- Misses        733      734       +1
Impacted Files Coverage Δ
src/Controllers/PushController.js 95.45% <ø> (-0.07%) ⬇️
...dapters/Storage/Postgres/PostgresStorageAdapter.js 96.16% <100%> (ø) ⬆️
src/Push/PushWorker.js 92.45% <100%> (-2.1%) ⬇️
src/RestWrite.js 93.29% <0%> (-0.2%) ⬇️
src/Adapters/Auth/meetup.js 89.47% <0%> (+5.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29c2fad...ae29c7b. Read the comment docs.

@flovilmart
Copy link
Contributor Author

@acinader, what do you think?

@flovilmart flovilmart modified the milestones: 2.6.0, 2.5.2 Jul 2, 2017
@flovilmart flovilmart merged commit ad52ed6 into master Jul 3, 2017
@flovilmart flovilmart deleted the android-installation-badge branch July 3, 2017 14:16
@flovilmart flovilmart modified the milestones: 2.5.3, 2.5.2 Jul 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants