Skip to content

fix a typo #4000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 8, 2017
Merged

fix a typo #4000

merged 3 commits into from
Jul 8, 2017

Conversation

RiverAge
Copy link
Contributor

@RiverAge RiverAge commented Jul 5, 2017

it should be weixin not qq.

@RiverAge
fix typo
b2c9fc4 
it should be weixin not qq.
@codecov
Copy link

codecov bot commented Jul 5, 2017 •
edited
Loading

Codecov Report

Merging #4000 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4000   +/-   ##
=======================================
  Coverage   90.59%   90.59%           
=======================================
  Files         116      116           
  Lines        7793     7793           
=======================================
  Hits         7060     7060           
  Misses        733      733
Impacted Files Coverage Δ
src/Adapters/Auth/wechat.js 15.78% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d6b4f4...96d01d7. Read the comment docs.

flovilmart
flovilmart reviewed Jul 5, 2017
View reviewed changes
src/Adapters/Auth/wechat.js Outdated
@@ -8,7 +8,7 @@ function validateAuthData(authData) {
if (data.errcode == 0) {
return;
}
throw new Parse.Error(Parse.Error.OBJECT_NOT_FOUND, 'qq auth is invalid for this user.');
throw new Parse.Error(Parse.Error.OBJECT_NOT_FOUND, 'weixin auth is invalid for this user.');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or wechat?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weixin is usually used in Chinese.
Yes,wechat is better.

flovilmart
flovilmart previously approved these changes Jul 6, 2017
View reviewed changes
@codecov-io
Copy link

codecov-io commented Jul 6, 2017 •
edited by codecov bot
Loading

Codecov Report

Merging #4000 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4000      +/-   ##
==========================================
- Coverage   90.59%   90.58%   -0.02%     
==========================================
  Files         116      116              
  Lines        7793     7793              
==========================================
- Hits         7060     7059       -1     
- Misses        733      734       +1
Impacted Files Coverage Δ
src/Adapters/Auth/vkontakte.js 33.33% <0%> (ø) ⬆️
src/Adapters/Auth/wechat.js 15.78% <0%> (ø) ⬆️
src/RestWrite.js 93.29% <0%> (-0.2%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d6b4f4...dfec73e. Read the comment docs.

@RiverAge
Copy link
Contributor Author

RiverAge commented Jul 8, 2017

@flovilmart I think the second check of response is unnecessary!

@flovilmart
Copy link
Contributor

Yes! Very useless :)

@flovilmart flovilmart merged commit a26e4c7 into parse-community:master Jul 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flovilmart flovilmart flovilmart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RiverAge @codecov-io @flovilmart