Skip to content

Fix/user update issue #4123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 29, 2017
Merged

Fix/user update issue #4123

merged 2 commits into from
Aug 29, 2017

Conversation

flovilmart
Copy link
Contributor

when sending a PUT request on /classes/_User/:objectId, with authData set alongside other values, the server was not updating the object. This PR addresses that issue.

the _User object is not updated as soon as you pass some authData part of the PUT
@codecov
Copy link

codecov bot commented Aug 29, 2017

Codecov Report

Merging #4123 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4123      +/-   ##
==========================================
+ Coverage   90.74%   90.79%   +0.05%     
==========================================
  Files         116      116              
  Lines        7939     7941       +2     
==========================================
+ Hits         7204     7210       +6     
+ Misses        735      731       -4
Impacted Files Coverage Δ
src/RestWrite.js 93% <100%> (+0.02%) ⬆️
...dapters/Storage/Postgres/PostgresStorageAdapter.js 96.58% <0%> (+0.11%) ⬆️
src/Adapters/Storage/Mongo/MongoTransform.js 84.83% <0%> (+0.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a103871...fa9de0d. Read the comment docs.

@flovilmart
Copy link
Contributor Author

@acinader I start growing tired of fixing that method...

@flovilmart flovilmart merged commit 2e1ba66 into master Aug 29, 2017
@flovilmart flovilmart deleted the fix/user-update-issue branch August 29, 2017 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants