Skip to content

Postgres: Properly handle undefined field values #4186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Sep 19, 2017

Prevents UnhandledPromiseRejectionWarning: Unhandled promise rejection when building queries.

This specifically happens when passing installationId=undefined on _Session

Prevents `UnhandledPromiseRejectionWarning: Unhandled promise rejection` when building queries.
@codecov
Copy link

codecov bot commented Sep 19, 2017

Codecov Report

Merging #4186 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4186      +/-   ##
=========================================
+ Coverage   92.19%   92.2%   +0.01%     
=========================================
  Files         116     116              
  Lines        8085    8085              
=========================================
+ Hits         7454    7455       +1     
+ Misses        631     630       -1
Impacted Files Coverage Δ
...dapters/Storage/Postgres/PostgresStorageAdapter.js 96.5% <100%> (ø) ⬆️
src/RestWrite.js 93.34% <0%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 406a21e...844b5f0. Read the comment docs.

@flovilmart flovilmart merged commit 9371958 into parse-community:master Sep 19, 2017
@dplewis dplewis deleted the pg-handle-undefined-field branch September 19, 2017 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants