Add support for expiration interval in Push #4202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4202 +/- ##
=========================================
+ Coverage 92.44% 92.5% +0.06%
=========================================
Files 118 118
Lines 8155 8169 +14
=========================================
+ Hits 7539 7557 +18
+ Misses 616 612 -4
Continue to review full report at Codecov.
|
marvelm
force-pushed
the
feature/expiration-time
branch
2 times, most recently
from
1c7f314 to
ed89a61
Compare
marvelm
force-pushed
the
feature/expiration-time
branch
from
ed89a61 to
b89d77b
Compare
|
@flovilmart I've fixed the coverage issue. |
|
100% diff hit, I like it! @montymxb what do you think ? |
flovilmart
approved these changes
Oct 25, 2017
|
@flovilmart looks like a nice addition 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
expiration_intervalparameter in the Push controller