⚡ Release 2.6.4 #4287
Merged
⚡ Release 2.6.4 #4287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4287 +/- ##
==========================================
+ Coverage 92.44% 92.47% +0.02%
==========================================
Files 118 118
Lines 8155 8155
==========================================
+ Hits 7539 7541 +2
+ Misses 616 614 -2
Continue to review full report at Codecov.
|
flovilmart
commented
Oct 23, 2017
| @@ -265,7 +265,7 @@ module.exports.ParseServerOptions = { | |||
| "default": 10 | |||
| }, | |||
| "port": { | |||
| "env": "PARSE_SERVER_PORT", | |||
| "env": "PORT", | |||
There was a problem hiding this comment.
this was dumbly competing with k8s when your service is named PARSE_SERVER, k8s exposed it as an env variable, but this is not a port (int) but the tcp URL for the service 🤕🔫
natanrolnik
approved these changes
Oct 25, 2017
|
Seems there are some flaky tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.