Skip to content

Fixes Issue unsetting in beforeSave doesn't allow object creation #4610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 8, 2018
Merged

Fixes Issue unsetting in beforeSave doesn't allow object creation #4610

merged 3 commits into from
Mar 8, 2018

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Mar 8, 2018

Closes: #4523

@codecov
Copy link

codecov bot commented Mar 8, 2018 •
edited
Loading

Codecov Report

Merging #4610 into master will decrease coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4610      +/-   ##
==========================================
- Coverage   92.67%   92.62%   -0.05%     
==========================================
  Files         119      119              
  Lines        8558     8560       +2     
==========================================
- Hits         7931     7929       -2     
- Misses        627      631       +4
Impacted Files Coverage Δ
src/Controllers/DatabaseController.js 94.58% <100%> (+0.02%) ⬆️
src/Adapters/Auth/meetup.js 84.21% <0%> (-5.27%) ⬇️
src/RestWrite.js 93.23% <0%> (-0.37%) ⬇️
...dapters/Storage/Postgres/PostgresStorageAdapter.js 97.11% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f03e35f...c118082. Read the comment docs.

@dplewis dplewis requested a review from flovilmart March 8, 2018 15:33
flovilmart
flovilmart approved these changes Mar 8, 2018
View reviewed changes
Copy link
Contributor

@flovilmart flovilmart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok

@dplewis
Copy link
Member Author

dplewis commented Mar 8, 2018

Thanks

@dplewis dplewis merged commit f0674df into parse-community:master Mar 8, 2018
@dplewis dplewis deleted the clp-beforehook branch March 8, 2018 16:31
UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
@dplewis
Fixes Issue unsetting in beforeSave doesn't allow object creation (pa…
7c63833 
…rse-community#4610)

* skip unset fields on canAddField

* removed fit

* add null check
This was referenced Aug 31, 2022
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flovilmart flovilmart flovilmart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dplewis @flovilmart