Skip to content

Fixes issue related to flow types #4724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 1, 2018
Merged

Fixes issue related to flow types #4724

merged 3 commits into from
May 1, 2018

Conversation

flovilmart
Copy link
Contributor

@flovilmart flovilmart commented Apr 15, 2018

closes #4722

@codecov
Copy link

codecov bot commented Apr 15, 2018

Codecov Report

Merging #4724 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4724      +/-   ##
==========================================
+ Coverage   92.64%   92.64%   +<.01%     
==========================================
  Files         119      119              
  Lines        8582     8583       +1     
==========================================
+ Hits         7951     7952       +1     
  Misses        631      631
Impacted Files Coverage Δ
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 90.85% <ø> (ø) ⬆️
...dapters/Storage/Postgres/PostgresStorageAdapter.js 97.15% <100%> (-0.09%) ⬇️
src/Routers/PushRouter.js 92.85% <0%> (-3.58%) ⬇️
src/RestWrite.js 93.6% <0%> (+0.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebf65bf...f5b5cdf. Read the comment docs.

@addisonElliott
Copy link
Contributor

Tested this PR and it works on my system at solving the issue. Looks good to me.

@addisonElliott
Copy link
Contributor

@flovilmart Anything we are waiting on for this PR?

@flovilmart flovilmart merged commit fad7b46 into master May 1, 2018
@flovilmart flovilmart deleted the fix/4722 branch May 1, 2018 11:37
@flovilmart
Copy link
Contributor Author

@addisonElliott you're right :) merged!

UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
* Fixes issue related to flow types

* Improves type inference on where clause, index

* run parse-server start on liveQueryServer only on mongo, state leaks on postgres
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running tests causes Flow exception
2 participants