Skip to content

remove runtime dependency on request #5076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2018
Merged

remove runtime dependency on request #5076

merged 1 commit into from
Sep 23, 2018

Conversation

flovilmart
Copy link
Contributor

No description provided.

@flovilmart flovilmart requested a review from acinader September 23, 2018 15:09
@codecov
Copy link

codecov bot commented Sep 23, 2018

Codecov Report

Merging #5076 into master will decrease coverage by 0.03%.
The diff coverage is 92.64%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5076      +/-   ##
==========================================
- Coverage   93.75%   93.71%   -0.04%     
==========================================
  Files         122      123       +1     
  Lines        8859     8867       +8     
==========================================
+ Hits         8306     8310       +4     
- Misses        553      557       +4
Impacted Files Coverage Δ
src/request.js 100% <100%> (ø)
src/ParseServer.js 96.74% <100%> (-0.03%) ⬇️
src/Controllers/HooksController.js 94.64% <84.21%> (-1.79%) ⬇️
src/Routers/IAPValidationRouter.js 85% <85.71%> (-0.37%) ⬇️
src/cloud-code/httpRequest.js 98.14% <96.77%> (-1.86%) ⬇️
...dapters/Storage/Postgres/PostgresStorageAdapter.js 97.25% <0%> (-0.09%) ⬇️
src/RestWrite.js 93.14% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4dc4a3a...9b2b7ed. Read the comment docs.

Copy link
Contributor

@acinader acinader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. what prompted you to do this?

@flovilmart
Copy link
Contributor Author

The request package has 22 dependencies, some have security issues. We don’t need those at runtime as request is never exposed.

@flovilmart flovilmart merged commit 93a0017 into master Sep 23, 2018
@flovilmart flovilmart deleted the no-request branch September 23, 2018 16:31
UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants