Skip to content

PG: Updating mixed array test #5252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 18, 2018
Merged

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Dec 18, 2018

Currently we can save a mixed array but not update

Currently we can save a mixed array but not update
@codecov
Copy link

codecov bot commented Dec 18, 2018

Codecov Report

Merging #5252 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5252      +/-   ##
==========================================
+ Coverage    93.9%   93.92%   +0.01%     
==========================================
  Files         123      123              
  Lines        8953     8965      +12     
==========================================
+ Hits         8407     8420      +13     
+ Misses        546      545       -1
Impacted Files Coverage Δ
...dapters/Storage/Postgres/PostgresStorageAdapter.js 97.14% <100%> (+0.02%) ⬆️
src/RestWrite.js 93.24% <0%> (-0.37%) ⬇️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 92.21% <0%> (+0.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b3da8b...83144dc. Read the comment docs.

@dplewis dplewis requested a review from flovilmart December 18, 2018 20:25
@dplewis
Copy link
Member Author

dplewis commented Dec 18, 2018

@vitaly-t I think I have a solution for this but a cleaner solution would be nice.

@dplewis dplewis requested a review from vitaly-t December 18, 2018 23:25
Copy link
Contributor

@vitaly-t vitaly-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. If it works, then no point rewriting in native pg-promise syntax. Maybe later.

@dplewis dplewis merged commit 631b168 into parse-community:master Dec 18, 2018
@dplewis dplewis deleted the pg-mixed-array branch December 18, 2018 23:38
lukyanov added a commit to Skript/parse-server that referenced this pull request Feb 12, 2019
UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
* PG: Updating mixed array test

Currently we can save a mixed array but not update

* build array instead of casting

* fix test

* add recursion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants