Skip to content

Fix #5678 #5681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 13, 2019
Merged

Fix #5678 #5681

merged 3 commits into from
Jun 13, 2019

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Jun 13, 2019

No description provided.

@codecov
Copy link

codecov bot commented Jun 13, 2019

Codecov Report

Merging #5681 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5681      +/-   ##
==========================================
- Coverage   94.19%   94.16%   -0.03%     
==========================================
  Files         129      129              
  Lines        9248     9240       -8     
==========================================
- Hits         8711     8701      -10     
- Misses        537      539       +2
Impacted Files Coverage Δ
src/Routers/FeaturesRouter.js 100% <ø> (ø) ⬆️
...dapters/Storage/Postgres/PostgresStorageAdapter.js 96.81% <ø> (-0.01%) ⬇️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 92.45% <100%> (-0.08%) ⬇️
src/RestWrite.js 93.15% <0%> (-0.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 089b809...7af4944. Read the comment docs.

@acinader
Copy link
Contributor

acinader commented Jun 13, 2019

while this fix seems fine, my question at this point is: what do we get out of including the mysql in server info? Thinking about why this is an issue, I'm pretty convinced that a production deployment should never allow the parse-server to ask this question as the parse-server doesn't need and shouldn't have the rights.

cc: @oallouch

@dplewis
Copy link
Member Author

dplewis commented Jun 13, 2019

@acinader @oallouch I removed this feature as there a lot of use cases where this wouldn't work. Such as ensuring users have admin access, which isn't always the case.

@dplewis dplewis requested a review from acinader June 13, 2019 18:36
@dplewis dplewis merged commit 7590ee9 into master Jun 13, 2019
@dplewis dplewis deleted the db-version-fix branch June 13, 2019 18:41
@oallouch
Copy link
Contributor

I understand. Hope I can help with something else.

UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants