Skip to content

Fix 5651 #5684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 13, 2019
Merged

Fix 5651 #5684

merged 2 commits into from
Jun 13, 2019

Conversation

davimacedo
Copy link
Member

Fix #5651

@acinader acinader requested a review from dplewis June 13, 2019 17:44
@dplewis
Copy link
Member

dplewis commented Jun 13, 2019

The issue comes from https://github.com/parse-community/parse-server/blob/master/src/Controllers/DatabaseController.js#L1551

updateSchemaWithIndexes should be called in performInitialization and performIntialization should be called after all the promises are resolved.

Thats why its flaky because those promises run in parallel

@davimacedo
Copy link
Member Author

Do you see any potential problem related to them running in parallel besides the flaky tests? Otherwise we can just fix the tests.

@codecov
Copy link

codecov bot commented Jun 13, 2019

Codecov Report

Merging #5684 into master will decrease coverage by 12.15%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #5684       +/-   ##
===========================================
- Coverage   94.19%   82.03%   -12.16%     
===========================================
  Files         129      129               
  Lines        9248     9248               
===========================================
- Hits         8711     7587     -1124     
- Misses        537     1661     +1124
Impacted Files Coverage Δ
...dapters/Storage/Postgres/PostgresStorageAdapter.js 3.17% <0%> (-93.66%) ⬇️
src/Adapters/Storage/Postgres/PostgresClient.js 78.57% <0%> (-7.15%) ⬇️
src/Controllers/UserController.js 93.45% <0%> (-0.94%) ⬇️
src/Routers/UsersRouter.js 93.54% <0%> (-0.65%) ⬇️
src/RestWrite.js 93.49% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 089b809...4582dcf. Read the comment docs.

@dplewis
Copy link
Member

dplewis commented Jun 13, 2019

Not many people use the indexes API (as it needs some work) but having them consistently at startup would be great.

@davimacedo
Copy link
Member Author

I understand it is already running at startup, right?

@dplewis dplewis merged commit 8b667cf into parse-community:master Jun 13, 2019
UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
* Fix 5651

* Fix User initilization test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flakey Tests
2 participants