Move npmignore blacklist to package.json whitelist #636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "files": [ | ||
| "bin/", | ||
| "lib/", | ||
| "src/", |
There was a problem hiding this comment.
Not sure why would we want src/ here, since it's non-compiled version of lib.
|
This is an unfortunate tradeoff. If you want to still use the npm |
|
👍 Sounds good, lgtm otherwise. |
|
Actually, let's try removing the src directory and just see what breaks :) It might work. |
|
I am officially excited to see this pull request |
andrewimm
force-pushed
the
andrewi.ship_less
branch
from
3596c04 to
f3286f9
Compare
|
@andrewimm updated the pull request. |
nlutsenko
added a commit
that referenced
this pull request
Feb 24, 2016
Move npmignore blacklist to package.json whitelist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces blacklisting with whitelisting, to specify which files go up to npm to be installed by users.
This prevents
.babelrcand other build configurations from being shipped to users, making it less likely that their build processes break (the RN packager in particular dislikes this).