-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Fix Unknow type merge bug on overloaded types #6494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Unknow type merge bug on overloaded types #6494
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6494 +/- ##
==========================================
+ Coverage 93.92% 93.97% +0.04%
==========================================
Files 169 169
Lines 11808 11819 +11
==========================================
+ Hits 11091 11107 +16
+ Misses 717 712 -5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@davimacedo ex: This works
Throw an error, it seems to be related about keys/includes
Get an error on product.ID |
* Fix Unknow type bug on overloaded types * check args too
We got a subtile bug on named mutation with variables that contains type from custom schema overloaded on an auto schema field (see fixed test use case).