fix potential issue with setting geoNear.query to undefined #6696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test cases do not have the `query` parameter set in $geoNear aggregation stage. this is to test for a reported potential issue when the parameter is not set.
Codecov Report
@@ Coverage Diff @@
## master #6696 +/- ##
==========================================
- Coverage 93.92% 93.87% -0.05%
==========================================
Files 169 169
Lines 12209 12209
==========================================
- Hits 11467 11461 -6
- Misses 742 748 +6
Continue to review full report at Codecov.
|
mtrezza
changed the title
|
This PR solves the geoNear.query undefined problem |
dplewis
approved these changes
Sep 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a potential issue as reported in #6540.
$geoNear.queryparameter will not be set toundefinedif no query is given.Even though the issue in #6540 could not be reproduced (test cases passed for MongoDB 4.0.4, 4.3.2 when
$geoNear.queryparameter is set toundefined) the issue may occur only with certain MongoDB versions or in certain setups.