Add findOneAndDelete, findOneAndModify to MongoCollection, move most of usages to it. #759
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlutsenko
force-pushed
the
nlutsenko.storage.findAndDoMagic
branch
from
541029c to
4049ce4
Compare
|
@nlutsenko updated the pull request. |
nlutsenko
added a commit
that referenced
this pull request
Mar 2, 2016
…oMagic Add findOneAndDelete, findOneAndModify to MongoCollection, move most of usages to it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Atomic find and delete if it exists, which directly translates to Postgres
Atomic find and update if it exists, which also translates to Postgres.
There is a behavior difference here compared to before - it returns the object with the changes applied, but that's ok and actually simplifies our stuff by a lot.
Move everything, but the Schema.js to it (need few more changes there to support this).
cc @lacker since you are going to be probably interested in this.