Skip to content

ci: fix flaky Apple Game Center tests #8163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 14, 2022

Conversation

dblythy
Copy link
Member

@dblythy dblythy commented Sep 12, 2022

New Pull Request Checklist

Issue Description

CI is flaky

Related issue: #8057

Approach

Attempts to close #8057

TODOs before merging

  • Add tests
  • A changelog entry is created automatically using the pull request title (do not manually add a changelog entry)

@parse-github-assistant
Copy link

parse-github-assistant bot commented Sep 12, 2022

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@codecov
Copy link

codecov bot commented Sep 12, 2022

Codecov Report

Merging #8163 (a32b59f) into alpha (7c32bfe) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            alpha    #8163      +/-   ##
==========================================
- Coverage   94.20%   94.19%   -0.02%     
==========================================
  Files         182      182              
  Lines       13720    13720              
==========================================
- Hits        12925    12923       -2     
- Misses        795      797       +2     
Impacted Files Coverage Δ
src/ParseServerRESTController.js 96.96% <0.00%> (-1.52%) ⬇️
src/RestWrite.js 94.42% <0.00%> (-0.16%) ⬇️
src/Controllers/DatabaseController.js 93.75% <0.00%> (-0.15%) ⬇️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 93.16% <0.00%> (+0.21%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mtrezza mtrezza changed the title fix: ci flaky ci: fix flaky Apple Game Center tests Sep 12, 2022
@dblythy
Copy link
Member Author

dblythy commented Sep 14, 2022

@mtrezza I'm pretty sure this is good to merge, and postgres is just being flaky

@dblythy dblythy requested a review from a team September 14, 2022 14:19
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mtrezza mtrezza merged commit c85bc01 into parse-community:alpha Sep 14, 2022
@dblythy dblythy deleted the fix-ci-cert branch September 14, 2022 14:35
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.3.0-alpha.22

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Sep 16, 2022
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.4.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Oct 29, 2022
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.4.0-alpha.1

@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.4.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Nov 19, 2022
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.4.0

@parseplatformorg parseplatformorg added the state:released-5.x.x Released as LTS version label Nov 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released Released as stable version state:released-5.x.x Released as LTS version state:released-alpha Released as alpha version state:released-beta Released as beta version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky Apple Game Center test
3 participants