Skip to content

test: fix flaky Apple Game Center tests #8204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 1, 2022

Conversation

dblythy
Copy link
Member

@dblythy dblythy commented Sep 29, 2022

New Pull Request Checklist

Issue Description

Attempts to fix flaky gcenter tests.

Related issue: #8057
Closes: #8057

Approach

TODOs before merging

  • Add tests
  • A changelog entry is created automatically using the pull request title (do not manually add a changelog entry)

@parse-github-assistant
Copy link

parse-github-assistant bot commented Sep 29, 2022

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@codecov
Copy link

codecov bot commented Sep 29, 2022

Codecov Report

Base: 94.17% // Head: 86.88% // Decreases project coverage by -7.29% ⚠️

Coverage data is based on head (33027a7) compared to base (0388956).
Patch has no changes to coverable lines.

❗ Current head 33027a7 differs from pull request most recent head 3fb30b5. Consider uploading reports for the commit 3fb30b5 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##            alpha    #8204      +/-   ##
==========================================
- Coverage   94.17%   86.88%   -7.30%     
==========================================
  Files         182      182              
  Lines       13744    13744              
==========================================
- Hits        12944    11942    -1002     
- Misses        800     1802    +1002     
Impacted Files Coverage Δ
src/Adapters/Storage/Mongo/MongoCollection.js 4.76% <0.00%> (-92.86%) ⬇️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 11.91% <0.00%> (-81.28%) ⬇️
src/Adapters/Cache/RedisCacheAdapter.js 12.28% <0.00%> (-75.44%) ⬇️
src/Adapters/Files/GridFSBucketAdapter.js 10.65% <0.00%> (-68.86%) ⬇️
...rc/Adapters/Storage/Mongo/MongoSchemaCollection.js 35.48% <0.00%> (-62.37%) ⬇️
src/GraphQL/loaders/filesMutations.js 37.93% <0.00%> (-41.38%) ⬇️
src/Adapters/Storage/Mongo/MongoTransform.js 48.51% <0.00%> (-39.91%) ⬇️
src/Adapters/Auth/gcenter.js 59.52% <0.00%> (-34.53%) ⬇️
src/Routers/SessionsRouter.js 65.71% <0.00%> (-25.72%) ⬇️
src/GraphQL/transformers/mutation.js 83.96% <0.00%> (-13.21%) ⬇️
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dblythy
Copy link
Member Author

dblythy commented Sep 29, 2022

1st test run fails due to flaky postgres tests - closing and reopening to check another test run

@dblythy dblythy closed this Sep 29, 2022
@dblythy dblythy reopened this Sep 29, 2022
@mtrezza
Copy link
Member

mtrezza commented Sep 29, 2022

No flaky Gamecenter test observed, re-running all tests to see whether they pass again

@mtrezza
Copy link
Member

mtrezza commented Sep 30, 2022

No flaky tests observed, again re-running

@mtrezza mtrezza changed the title fix: flaky tests test: fix flaky Apple Game Center tests Oct 1, 2022
@mtrezza mtrezza merged commit eb649f2 into parse-community:alpha Oct 1, 2022
@dblythy dblythy deleted the fix-flaky-tests branch October 1, 2022 10:16
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.3.0-alpha.28

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Oct 11, 2022
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.4.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Oct 29, 2022
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.4.0-alpha.1

@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.4.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Nov 19, 2022
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.4.0

@parseplatformorg parseplatformorg added the state:released-5.x.x Released as LTS version label Nov 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released Released as stable version state:released-5.x.x Released as LTS version state:released-alpha Released as alpha version state:released-beta Released as beta version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky Apple Game Center test
3 participants