Skip to content

ci: Fix flaky definitions check #8504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
May 29, 2023
Merged

ci: Fix flaky definitions check #8504

merged 13 commits into from
May 29, 2023

Conversation

dblythy
Copy link
Member

@dblythy dblythy commented Apr 12, 2023 •
edited
Loading

Pull Request

Issue

Closes: #8579

Approach

Tasks

  • Add tests
  • Add changes to documentation (guides, repository pages, code comments)
  • Add security check
  • Add new Parse Error codes to Parse JS SDK

@parse-github-assistant
Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title ci: fix Definitions Check ci: Fix Definitions Check Apr 12, 2023
@parse-github-assistant
Copy link

parse-github-assistant bot commented Apr 12, 2023 •
edited
Loading

Thanks for opening this pull request!

@codecov
Copy link

codecov bot commented Apr 12, 2023 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: +0.02 🎉

Comparison is base (6722110) 94.32% compared to head (33158ad) 94.34%.

❗ Current head 33158ad differs from pull request most recent head 935a7f0. Consider uploading reports for the commit 935a7f0 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##            alpha    #8504      +/-   ##
==========================================
+ Coverage   94.32%   94.34%   +0.02%     
==========================================
  Files         183      183              
  Lines       14576    14576              
==========================================
+ Hits        13749    13752       +3     
+ Misses        827      824       -3

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dblythy dblythy closed this Apr 12, 2023
@dblythy dblythy reopened this May 22, 2023
@mtrezza
Copy link
Member

mtrezza commented May 22, 2023

I thought it was flaky, good fix. Is this ready for merge?

@dblythy
Copy link
Member Author

dblythy commented May 29, 2023

It is still flaky, I haven't changed anything just yet - trying to identify the cause

@dblythy dblythy closed this May 29, 2023
@dblythy dblythy reopened this May 29, 2023
@dblythy dblythy closed this May 29, 2023
@dblythy dblythy reopened this May 29, 2023
@dblythy dblythy closed this May 29, 2023
@dblythy dblythy reopened this May 29, 2023
@dblythy dblythy closed this May 29, 2023
@dblythy dblythy reopened this May 29, 2023
@dblythy
Copy link
Member Author

dblythy commented May 29, 2023

Screenshot 2023-05-29 at 5 28 33 pm

Changes seem to resolve the issue

@mtrezza
Copy link
Member

mtrezza commented May 29, 2023

Nice, can we merge this?

@dblythy
Copy link
Member Author

dblythy commented May 29, 2023

Yep! It’s good to go

mtrezza
mtrezza approved these changes May 29, 2023
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mtrezza mtrezza changed the title ci: Fix Definitions Check ci: Fix flaky definitions check May 29, 2023
@mtrezza mtrezza merged commit 505dd6b into parse-community:alpha May 29, 2023
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.1.0-alpha.17

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Jun 7, 2023
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.3.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Jun 10, 2023
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.3.0-alpha.1

@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.3.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtrezza mtrezza mtrezza approved these changes

Assignees
No one assigned
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI definitions check flaky
3 participants
@dblythy @mtrezza @parseplatformorg