Skip to content

refactor: Incorrect spelling in hooks error message #8585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 28, 2023

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented May 28, 2023

Pull Request

Issue

The word exits should be exists when a Hook error is thrown.

Closes: n/a

Approach

Fix spelling

Tasks

  • Update tests

@parse-github-assistant
Copy link

parse-github-assistant bot commented May 28, 2023

Thanks for opening this pull request!

  • ❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Closes: #123 in the PR description, so I can recognize it.

@codecov
Copy link

codecov bot commented May 28, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (a37d1ee) 94.34% compared to head (05d3c3e) 94.34%.

❗ Current head 05d3c3e differs from pull request most recent head 2f99c1e. Consider uploading reports for the commit 2f99c1e to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##            alpha    #8585   +/-   ##
=======================================
  Coverage   94.34%   94.34%           
=======================================
  Files         183      183           
  Lines       14576    14576           
=======================================
+ Hits        13751    13752    +1     
+ Misses        825      824    -1     
Impacted Files Coverage Δ
src/Controllers/HooksController.js 94.73% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mtrezza mtrezza changed the title fix: Spelling in hooks error message fix: Incorrect spelling in hooks error message May 28, 2023
@mtrezza mtrezza changed the title fix: Incorrect spelling in hooks error message refactor: Incorrect spelling in hooks error message May 28, 2023
@mtrezza mtrezza merged commit 5eb690c into parse-community:alpha May 28, 2023
@cbaker6 cbaker6 deleted the patch-1 branch May 28, 2023 11:36
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.1.0-alpha.15

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label May 28, 2023
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.3.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Jun 10, 2023
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.3.0-alpha.1

@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.3.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants