Skip to content

Commit 19371f1

Browse files
knakadpengk19
authored andcommitted
change: enable signature-differs pylint check (aws#915)
1 parent efbc45c commit 19371f1

File tree

3 files changed

+6
-3
lines changed

3 files changed

+6
-3
lines changed

.pylintrc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,6 @@ disable=
8787
attribute-defined-outside-init, # TODO: Fix scope
8888
protected-access, # TODO: Fix access
8989
abstract-method, # TODO: Fix abstract methods
90-
signature-differs, # TODO: Fix signature overrides
9190
unidiomatic-typecheck, # TODO: Fix typechecks
9291
wrong-import-order, # TODO: Fix import order
9392
no-else-return, # TODO: Remove unnecessary elses

src/sagemaker/amazon/lda.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,9 @@ def create_model(self, vpc_config_override=VPC_CONFIG_DEFAULT):
120120
vpc_config=self.get_vpc_config(vpc_config_override),
121121
)
122122

123-
def _prepare_for_training(self, records, mini_batch_size, job_name=None):
123+
def _prepare_for_training( # pylint: disable=signature-differs
124+
self, records, mini_batch_size, job_name=None
125+
):
124126
# mini_batch_size is required, prevent explicit calls with None
125127
if mini_batch_size is None:
126128
raise ValueError("mini_batch_size must be set")

src/sagemaker/amazon/ntm.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,9 @@ def create_model(self, vpc_config_override=VPC_CONFIG_DEFAULT):
151151
vpc_config=self.get_vpc_config(vpc_config_override),
152152
)
153153

154-
def _prepare_for_training(self, records, mini_batch_size, job_name=None):
154+
def _prepare_for_training( # pylint: disable=signature-differs
155+
self, records, mini_batch_size, job_name=None
156+
):
155157
if mini_batch_size is not None and (mini_batch_size < 1 or mini_batch_size > 10000):
156158
raise ValueError("mini_batch_size must be in [1, 10000]")
157159
super(NTM, self)._prepare_for_training(

0 commit comments

Comments
 (0)