build(pom.xml): update ErrorProne to 2.3.3

- enable back ParameterName check
- disable MixedMutabilityReturnType check
- fix errors about using system timezone
  (see http://errorprone.info/bugpattern/JavaTimeDefaultTimeZone and #76)

Changelog: https://github.com/google/error-prone/releases/tag/v2.3.3

No functional changes.

Author: php-coder

pom.xml

@@ -494,7 +494,7 @@
 		<dockerfile.plugin.version>1.4.6</dockerfile.plugin.version>
 		<enforcer.plugin.version>1.4.1</enforcer.plugin.version>
 		<error-prone-javac.version>9+181-r4173-1</error-prone-javac.version>
-		<error-prone.version>2.3.2</error-prone.version>
+		<error-prone.version>2.3.3</error-prone.version>
 		<failsafe.plugin.version>2.22.0</failsafe.plugin.version>
 		<fest.assert.version>2.0M8</fest.assert.version>
 		<gmavenplus.plugin.version>1.5</gmavenplus.plugin.version>
@@ -804,9 +804,9 @@
 						<!--
 							The following checks have been disabled:
 							- MissingOverride: produce false positives with @Getter from Lombok
-							- ParameterName: workaround for https://github.com/google/error-prone/issues/780
+							- MixedMutabilityReturnType: because I like to use Collections.empty*() methods
 						-->
-						<compilerArg>-Xplugin:ErrorProne -Xep:MissingOverride:OFF -Xep:ParameterName:OFF</compilerArg>
+						<compilerArg>-Xplugin:ErrorProne -Xep:MissingOverride:OFF -Xep:MixedMutabilityReturnType:OFF</compilerArg>
 					</compilerArgs>
 					<annotationProcessorPaths>
 						<path>

src/main/java/ru/mystamps/web/controller/editor/ReplaceRepeatingSpacesEditor.java

@@ -33,9 +33,7 @@ public class ReplaceRepeatingSpacesEditor extends PropertyEditorSupport {
 
 	@Override
 	public void setAsText(String name) throws IllegalArgumentException {
-		String text = name;
-
-		text = name.trim();
+		String text = name.trim();
 
 		if (text.contains("  ")) {
 			text = REPEATING_SPACES.matcher(text).replaceAll(" ");

src/main/java/ru/mystamps/web/feature/series/ReleaseDateIsNotInFutureValidator.java

@@ -24,6 +24,7 @@
 import java.time.LocalDate;
 import java.time.Year;
 import java.time.YearMonth;
+import java.time.ZoneOffset;
 
 /**
  * @author Sergey Chechenev
@@ -73,7 +74,7 @@ private static boolean yearInFuture(AddSeriesDto dto) {
 		}
 
 		return Year.of(dto.getYear())
-			.isAfter(Year.now());
+			.isAfter(Year.now(ZoneOffset.UTC));
 	}
 
 	private static boolean yearAndMonthInFuture(AddSeriesDto dto) {
@@ -82,7 +83,7 @@ private static boolean yearAndMonthInFuture(AddSeriesDto dto) {
 		}
 
 		return YearMonth.of(dto.getYear(), dto.getMonth())
-			.isAfter(YearMonth.now());
+			.isAfter(YearMonth.now(ZoneOffset.UTC));
 	}
 
 	private static boolean dateInFuture(AddSeriesDto dto) {
@@ -91,7 +92,7 @@ private static boolean dateInFuture(AddSeriesDto dto) {
 		}
 
 		return LocalDate.of(dto.getYear(), dto.getMonth(), dto.getDay())
-			.isAfter(LocalDate.now());
+			.isAfter(LocalDate.now(ZoneOffset.UTC));
 	}
 
 }

src/main/java/ru/mystamps/web/feature/series/SeriesController.java

@@ -64,6 +64,7 @@
 import javax.validation.groups.Default;
 import java.io.IOException;
 import java.time.Year;
+import java.time.ZoneOffset;
 import java.util.Collections;
 import java.util.HashMap;
 import java.util.LinkedHashMap;
@@ -80,8 +81,7 @@
 @SuppressWarnings({ "PMD.AvoidDuplicateLiterals", "PMD.TooManyMethods", "PMD.GodClass" })
 public class SeriesController {
 
-	private static final Integer CURRENT_YEAR = Integer.valueOf(Year.now().getValue());
-	
+	private static final Integer CURRENT_YEAR;
 	private static final Map<Integer, Integer> YEARS;
 
 	private final CategoryService categoryService;
@@ -93,6 +93,7 @@ public class SeriesController {
 	private final ParticipantService participantService;
 
 	static {
+		CURRENT_YEAR = Integer.valueOf(Year.now(ZoneOffset.UTC).getValue());
 		YEARS = new LinkedHashMap<>();
 		for (Integer i = CURRENT_YEAR; i >= MIN_RELEASE_YEAR; i--) {
 			YEARS.put(i, i);

src/test/java/ru/mystamps/web/service/TestObjects.java

@@ -53,7 +53,6 @@
 import ru.mystamps.web.tests.Random;
 import ru.mystamps.web.util.SlugUtils;
 
-import java.math.BigDecimal;
 import java.nio.charset.StandardCharsets;
 import java.util.Collections;
 import java.util.Date;
@@ -77,7 +76,6 @@ public final class TestObjects {
 
 	private static final String TEST_NAME           = "Test Name";
 	private static final String TEST_URL            = "test.example.org";
-	private static final BigDecimal TEST_PRICE      = new BigDecimal("100.99");
 
 	private static final String TEST_ENTITY_NAME    = TEST_NAME;
 	private static final String TEST_ENTITY_SLUG    = "test-slug";

src/test/java/ru/mystamps/web/tests/Random.java

@@ -34,6 +34,7 @@
 import java.text.ParseException;
 import java.text.SimpleDateFormat;
 import java.time.Year;
+import java.time.ZoneOffset;
 import java.util.Arrays;
 import java.util.Date;
 import java.util.List;
@@ -187,7 +188,10 @@ public static String sellerName() {
 	}
 
 	public static Integer issueYear() {
-		return between(ValidationRules.MIN_RELEASE_YEAR, Year.now().getValue()).integer();
+		return between(
+			ValidationRules.MIN_RELEASE_YEAR,
+			Year.now(ZoneOffset.UTC).getValue()
+		).integer();
 	}
 
 	public static Integer quantity() {