Skip to content

Commit 90aca4b

Browse files
committed
JdbcSeriesDao{,Impl}: fix warnings from PMD about too many methods.
No functional changes.
1 parent 1895ec5 commit 90aca4b

File tree

4 files changed

+7
-2
lines changed

4 files changed

+7
-2
lines changed

src/main/java/ru/mystamps/web/dao/JdbcSeriesDao.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@
2020
import ru.mystamps.web.service.dto.SeriesInfoDto;
2121
import ru.mystamps.web.service.dto.SitemapInfoDto;
2222

23+
// TODO: move stamps related methods to separate interface (#88)
24+
@SuppressWarnings("PMD.TooManyMethods")
2325
public interface JdbcSeriesDao {
2426
Iterable<SitemapInfoDto> findAllForSitemap();
2527
Iterable<SeriesInfoDto> findLastAdded(int quantity, String lang);

src/main/java/ru/mystamps/web/dao/impl/JdbcSeriesDaoImpl.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,8 @@
3131
import ru.mystamps.web.service.dto.SeriesInfoDto;
3232
import ru.mystamps.web.service.dto.SitemapInfoDto;
3333

34-
@SuppressWarnings("PMD.AvoidDuplicateLiterals")
34+
// TODO: move stamps related methods to separate interface (#88)
35+
@SuppressWarnings({ "PMD.AvoidDuplicateLiterals", "PMD.TooManyMethods" })
3536
@RequiredArgsConstructor
3637
public class JdbcSeriesDaoImpl implements JdbcSeriesDao {
3738

src/main/java/ru/mystamps/web/service/SeriesService.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
import ru.mystamps.web.service.dto.SeriesInfoDto;
2626
import ru.mystamps.web.service.dto.SitemapInfoDto;
2727

28+
// TODO: move stamps related methods to separate interface (#88)
2829
@SuppressWarnings("PMD.TooManyMethods")
2930
public interface SeriesService {
3031
Integer add(AddSeriesDto dto, User user, boolean userCanAddComments);

src/main/java/ru/mystamps/web/service/SeriesServiceImpl.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,9 @@
4848
import ru.mystamps.web.service.dto.SitemapInfoDto;
4949
import ru.mystamps.web.util.CatalogUtils;
5050

51-
@RequiredArgsConstructor
51+
// TODO: move stamps related methods to separate interface (#88)
5252
@SuppressWarnings("PMD.TooManyMethods")
53+
@RequiredArgsConstructor
5354
public class SeriesServiceImpl implements SeriesService {
5455
private static final Logger LOG = LoggerFactory.getLogger(SeriesServiceImpl.class);
5556

0 commit comments

Comments
 (0)