Skip to content

Commit 9cdf3f9

Browse files
committed
ci(Dangerfile): remove checks for a branch name and a keyword in a PR description.
These checks had confused contributors a couple of times and they had tried to close a pull request and open a new one in order to fix the warnings. As these checks aren't so important I decided to decomission them. [skip ci]
1 parent 476b788 commit 9cdf3f9

File tree

1 file changed

+0
-14
lines changed

1 file changed

+0
-14
lines changed

Dangerfile

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -666,13 +666,6 @@ if File.file?(rf_report)
666666
print_errors_summary 'robotframework-maven-plugin', errors_count, 'https://github.com/php-coder/mystamps/wiki/integration-tests'
667667
end
668668

669-
if github.pr_body !~ /Addressed to #\d+/
670-
warn(
671-
"danger check: pull request **description** doesn't contain a link to original issue.\n"\
672-
"Consider adding a comment in the following format: `Addressed to #XXX` where `XXX` is an issue number"
673-
)
674-
end
675-
676669
commits = git.commits.size
677670
if commits > 1
678671
if git.commits.any? { |c| c.message =~ /^Merge branch/ || c.message =~ /^Merge remote-tracking branch/ }
@@ -690,13 +683,6 @@ if commits > 1
690683
end
691684
end
692685

693-
if github.branch_for_head !~ /^gh[0-9]+_/
694-
warn("danger check: branch `#{github.branch_for_head}` does not comply with our best practices. "\
695-
"Branch name should use the following scheme: `ghXXX_meaningful-name` where `XXX` is an issue number. "\
696-
"**Next time**, please, use this scheme :)"
697-
)
698-
end
699-
700686
js_file = %r{^src/main/javascript/.*\.js$}
701687
component_file = %r{^src/main/frontend/src/.*\.js$}
702688
css_file = %r{^src/main/webapp/.*\.css$}

0 commit comments

Comments
 (0)