Skip to content

Commit 2824194

Browse files
committed
deprecate DummyClient
1 parent e1710ba commit 2824194

File tree

3 files changed

+8
-2
lines changed

3 files changed

+8
-2
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,10 @@ The change log describes what is "Added", "Removed", "Changed" or "Fixed" betwee
88

99
- Plugins are now displayed with their FQCN instead of service id.
1010

11+
### Deprecated
12+
13+
- The `DummyClient` interface.
14+
1115
## 1.6.0 - 2017-05-22
1216

1317
### Added

ClientFactory/DummyClient.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22

33
namespace Http\HttplugBundle\ClientFactory;
44

5+
@trigger_error('The '.__NAMESPACE__.'\DummyClient interface is deprecated since version 1.7 and will be removed in 2.0.', E_USER_DEPRECATED);
6+
57
use Http\Client\HttpAsyncClient;
68
use Http\Client\HttpClient;
79

DependencyInjection/HttplugExtension.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
use Http\Client\Common\FlexibleHttpClient;
77
use Http\Client\Common\HttpMethodsClient;
88
use Http\Client\Common\Plugin\AuthenticationPlugin;
9-
use Http\HttplugBundle\ClientFactory\DummyClient;
9+
use Http\Client\Common\PluginClient;
1010
use Http\HttplugBundle\ClientFactory\PluginClientFactory;
1111
use Http\HttplugBundle\Collector\ProfilePlugin;
1212
use Http\Message\Authentication\BasicAuth;
@@ -284,7 +284,7 @@ private function configureClient(ContainerBuilder $container, $clientName, array
284284
}
285285

286286
$container
287-
->register($serviceId, DummyClient::class)
287+
->register($serviceId, PluginClient::class)
288288
->setFactory([PluginClientFactory::class, 'createPluginClient'])
289289
->addArgument(
290290
array_map(

0 commit comments

Comments
 (0)