use-key-instead-of-name

Author: soullivaneuh

src/DependencyInjection/Configuration.php

@@ -664,7 +664,7 @@ private function createAuthenticationPluginNode(): NodeDefinition
 
                                 break;
                             case 'header':
-                                $this->validateAuthenticationType(['name', 'value'], $config, 'header');
+                                $this->validateAuthenticationType(['key', 'value'], $config, 'header');
 
                                 break;
                         }
@@ -682,7 +682,7 @@ private function createAuthenticationPluginNode(): NodeDefinition
                     ->scalarNode('password')->end()
                     ->scalarNode('token')->end()
                     ->scalarNode('service')->end()
-                    ->scalarNode('name')->end()
+                    ->scalarNode('key')->end()
                     ->scalarNode('value')->end()
                     ->arrayNode('params')->prototype('scalar')->end()
                     ->end()

src/DependencyInjection/HttplugExtension.php

@@ -384,7 +384,7 @@ private function configureAuthentication(ContainerBuilder $container, array $con
                     break;
                 case 'header':
                     $container->register($authServiceKey, Header::class)
-                        ->addArgument($values['name'])
+                        ->addArgument($values['key'])
                         ->addArgument($values['value']);
 
                     break;

tests/Resources/Fixtures/config/full.php

@@ -98,7 +98,7 @@
             ],
             'my_header' => [
                 'type' => 'header',
-                'name' => 'foo',
+                'key' => 'foo',
                 'value' => 'bar',
             ],
             'my_service' => [

tests/Resources/Fixtures/config/full.xml

@@ -58,7 +58,7 @@
                 <my_basic type="basic" username="foo" password="bar"/>
                 <my_wsse type="wsse" username="foo" password="bar"/>
                 <my_bearer type="bearer" token="foo"/>
-                <my_header type="header" name="foo" value="bar" />
+                <my_header type="header" key="foo" value="bar" />
                 <my_service type="service" service="my_auth_service"/>
             </authentication>
             <cache cache-pool="my_cache_pool" stream-factory="my_other_stream_factory">

tests/Resources/Fixtures/config/full.yml

@@ -67,7 +67,7 @@ httplug:
                 token: foo
             my_header:
                 type: header
-                name: foo
+                key: foo
                 value: bar
             my_service:
                 type: service

tests/Unit/DependencyInjection/ConfigurationTest.php

@@ -246,8 +246,9 @@ public function testSupportsAllConfigFormats(): void
                     ],
                     'my_header' => [
                         'type' => 'header',
-                        'name' => 'foo',
+                        'key' => 'foo',
                         'value' => 'bar',
+                        'params' => [],
                     ],
                     'my_service' => [
                         'type' => 'service',