Skip to content

display plugin fqcn instead of plugin service id #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2017
Merged

display plugin fqcn instead of plugin service id #179

merged 1 commit into from
Jul 3, 2017

Conversation

fbourigault
Copy link
Contributor

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets partially #109
Documentation screenshot updates
License MIT

What's in this PR?

This use the plugin FQCN instead of the service name in the profiler (see #109 (comment)).

pluginfqcn

@fbourigault fbourigault mentioned this pull request Jul 3, 2017
Closed
@fbourigault
Copy link
Contributor Author

Thanks for the review!

@fbourigault fbourigault merged commit 9df8e66 into php-http:master Jul 3, 2017
@fbourigault fbourigault deleted the display-plugin-fqcn branch July 3, 2017 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nyholm Nyholm Nyholm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fbourigault @Nyholm