Skip to content

guess client names from collected stacks #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 6, 2017
Merged

guess client names from collected stacks #180

merged 1 commit into from
Jul 6, 2017

Conversation

fbourigault
Copy link
Contributor

@fbourigault fbourigault commented Jul 6, 2017

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets partially #109
Documentation N/A
License MIT

This is a subset of #109 which aims to display clients names in the profiler from what is collected. The only "negative" change here is we no longer display empty tabs for clients which doesn't sent any request.

ToDo

  • Add basic Collector unit test.

@Nyholm
Copy link
Member

Nyholm commented Jul 6, 2017

Thank you for this PR.

@Nyholm Nyholm merged commit eec8c7c into php-http:master Jul 6, 2017
@fbourigault fbourigault deleted the collector-client-names branch July 6, 2017 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants