Skip to content

Revert "use service locator for configured client strategy" #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 17, 2017
Merged

Revert "use service locator for configured client strategy" #189

merged 1 commit into from
Jul 17, 2017

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Jul 15, 2017 •
edited
Loading

This reverts commit c5ac6da.

PR #185 made discovery so extra lazy so it does not work. See #188.

@Nyholm Nyholm requested a review from fbourigault July 15, 2017 14:28
fbourigault
fbourigault approved these changes Jul 17, 2017
View reviewed changes
Copy link
Contributor

@fbourigault fbourigault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can only approve as I didn't find a valid solution without breaking backward compatibility.

@fbourigault fbourigault merged commit 227eee2 into master Jul 17, 2017
@fbourigault
Copy link
Contributor

Thank you!

@fbourigault fbourigault deleted the revert-185 branch July 17, 2017 08:19
@fbourigault fbourigault mentioned this pull request Jul 17, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbourigault fbourigault fbourigault approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nyholm @fbourigault